Repository navigation
address-review: escalate a finding that asks to reverse an earlier fix - #123
Merged
Merged
Conversation
Two findings that want opposite behaviour are a behaviour choice, not a bug: changing it again only seeds the next round's finding (seen on a PR where the arrow-key behaviour changed three times in three rounds). The agent stops, names both findings and the fix between them, and waits for the maintainer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNDeh6Ai7WgSvQvTZVEHdg
allenhutchison
added
the
greptile:skip
allenhutchison
marked this pull request as ready for review
November 8, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Allen · project thread
Human overview
address-review gains one rule: when a finding asks the agent to undo or invert a behaviour it changed earlier in the same PR at a reviewer's request, the agent stops and brings both behaviours to the maintainer. It no longer changes the behaviour again. This comes from Allen's 2026-11-08 decision after Vycari/pepper-apple#198, where the arrow-key behaviour changed three times in three rounds.
AI reviewer
plugins/repo-ops/skills/address-review/SKILL.md, "Keep the PR to its brief": a new bullet before "A finding that contradicts the brief". The reply isDisputed:for a P0/P1 orDeferred:for a P2, naming both findings and the fix commit between them. The finding is listed under Needs the maintainer with the two behaviours as the options. The agent does not touch that behaviour until the maintainer answers.scripts/test-address-review-first-line.sh(24 passed) andscripts/check-links.pyare clean.Generated by Claude Code