Repository navigation
address-review: keep a PR to its brief; P2s fix-or-defer to one roll-up issue - #122
Merged
Merged
Conversation
…up issue The loop fixed every valid finding, P2s included, and every fix is new code the next round reviews. Small PRs grew 1.4-3x (Vycari pepper#6035: 358 -> ~1,000 lines) until a person redirected them. - P0/P1 block; P2s are the agent's call to fix or defer, every round. - From round 2, only P0/P1 are fixed in the PR; later P2s default to follow-ups. - Findings that contradict the linked issue's acceptance criteria are disputed. - Behaviour choices the brief does not make go to the maintainer. - All deferrals go to one roll-up issue per PR, tracked in the ledger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNDeh6Ai7WgSvQvTZVEHdg
allenhutchison
added
the
greptile:skip
allenhutchison
marked this pull request as ready for review
November 7, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Allen · project thread
Human overview
The review loop now keeps a PR inside its brief, which is its linked issue plus its stated scope. P0 and P1 findings still block. P2s are the agent's call: it can fix one or defer it. From round 2 on, only P0s and P1s get fixed in the PR. Everything deferred goes into one roll-up issue per PR. Before this, the loop fixed every valid finding, and each fix gave the next round something new to review, so small PRs grew 1.4 to 3 times (pepper#6035 went from 358 lines to about 1,000). This implements Allen's three decisions of 2026-11-07.
AI reviewer
What the diff does (
plugins/repo-ops/skills/address-review/SKILL.md, prose only)Review follow-ups from #<PR>, with one checklist line per finding. Later deferrals are appended to it, and it is recorded in the ledger asfollow-ups: <N>.vr-findingsnow says fix P0/P1s and the chosen P2s, and defer the rest.follow-upskey.Invariants:
Deferred: #Nis already a valid answer on final-gate threads (the existing filter accepts it with an issue reference), so deferring never holds the first-line hand-off. Severity is never lowered by this skill.Companion changes: a foreman PR (linked issue in the VR pack; VR stops re-raising P2s answered
Deferred:/Declined:), a review-memory prompt PR (the brief's acceptance criteria count as scope rules), and a vycari design-doc amendment.Verification:
scripts/test-address-review-first-line.shpassed 24/24, andscripts/check-links.pyis clean.Generated by Claude Code