add(upgrade-os): upgrade to hbsd14 - #13
Conversation
b6c4d1c to
b569733
Compare
b569733 to
8667c50
Compare
8667c50 to
918adc8
Compare
918adc8 to
39c2fca
Compare
39c2fca to
91bc447
Compare
91bc447 to
10b2ee3
Compare
frikilax
left a comment
frikilax
left a comment
There was a problem hiding this comment.
I think upgrade-os-to-14 and upgrade-os-to-15 could be merged in one single upgrade-major command, with the ability to give the selected major version (or not ? maybe not necessary, unless it's easier to ask the user for next major instead of computing/guessing it).
Also: couldn't this upgrade-major function use most of the already defined helper functions in regular upgrade-pkg and upgrade-os ?
| upgrade-pkg Upgrade the packages. | ||
| upgrade-os-to-14 Migrate system to HardenedBSD 14. | ||
| upgrade-os-to-15 Migrate system to HardenedBSD 15. | ||
| upgrade-mongodb Upgrade MongoDB version |
There was a problem hiding this comment.
No relation to the PR
Maybe better suited in the vulture-mongodb package
| if /sbin/zfs destroy "${_zpool}/${_dataset}@${_snap_to_delete}" || \ | ||
| /sbin/zfs destroy "${_zpool}/ROOT/$(get_current_BE)/${_dataset}@${_snap_to_delete}"; then |
There was a problem hiding this comment.
Prefer checking which dataset exist and show it to the user on removal
| if zfs_dataset_exists "${dataset}"; then | ||
| /sbin/zfs snap "${_zpool}/${dataset}@${_snapshot_name}" | ||
| /sbin/zfs snap "${_zpool}/${dataset}@${_snapshot_name}" || \ | ||
| /sbin/zfs snap "${_zpool}/ROOT/$(get_current_BE)/${dataset}@${_snapshot_name}" |
There was a problem hiding this comment.
...or maybe make a helper function to get the correct fullpath of a dataset, depending on ZFS structure (seeing as several lines were updated that way)
2 participants
Added