Fix OAuth and WebSocket V2 regressions#153
Open
tranceporter wants to merge 34 commits into
Open
Conversation
…hreading/lifecycle model, making (un)subscribing actions idempotent and introducing Pydantic models at input and output
… expecting only str and Enum
…and changed subscription_controller._bindings key from Subscription to new the binding_key. - added SubscriptionResolver which allow SubscriptionController to automatically detect binding_keys that need confirmation on (un)subscriptions - finished implementing ibkr_subscriptions
# Conflicts: # ibind/ibkr_ws_v2/ibkr_events.py
…marking as degraded across WsRuntime
…amed 'channel' to 'topic', implemented QueueSink as replacement of QueueController/Accessor chore(ws_v2): cleaned up ws_runtime and ws_transport
fix(ws_v2): fixed TransportEvent attempts refactor(ws_v2): renamed ClientInternalEvents to LifecycleEvents
…xport `WsEvent`, and relocate IBKR topic-to-event resolution into the router for clearer ownership fix(ws_v2): harden runtime shutdown and transport state improve runtime stop/close flow to set closed state consistently, separate graceful vs unexpected disconnects, and mark transport degraded when thread shutdown fails reduce websocket lifecycle log noise by moving thread start/stop logs to debug while keeping key connection, auth, and send events visible
…cate privacy, expecting imports to point at ibind.events. Also added docstrings
…tions for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on PR #151 /
feat/ws_v2and fixes reliability issues across V1 and V2.Highlights:
competing=Falselogging.Verification:
python -m pytest test/unit test/integration -q-> 182 passedpython -m ruff check .python -m bandit -r . -ll -x .git,.pytest_cache,build,dist,site-packagesIbkrWsClientV2,events, andsubscriptions