feat(raids): planner follow-ups — admin-as-officer editing + Manage Raiders search/rank filter#161
Merged
Merged
Conversation
…aiders search/rank filter Two follow-ups to #160: - A site admin who is ALSO a member of the guild can edit the raid plan like an officer (roles + placements). Admin alone is not enough — the planner belongs to the guild. The GET payload's is_officer flag reflects it so the UI enables autosave. Tests cover both the admin+member happy path and the admin-non-member 403. - Manage Raiders scales to large guilds: the roster payload now carries each member's guild rank (name + id), and the panel gains a rank dropdown (ordered by rank id) alongside the renamed search box. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #160, kept out of the rollout PR as requested:
ADMIN_DISCORD_IDS) who is also a member of the guild gets officer-grade edit rights on the planner (roles + placements), and the payload'sis_officerflag reflects it so autosave enables. Admin without a claimed character in the guild still gets 403 — the planner belongs to the guild. Both paths tested.rank/rank_id; the panel gets a rank dropdown (ordered by rank id) next to the search box, so finding characters in big guilds is a two-click affair.26 raid-planning tests green (3 new), full gates clean.
🤖 Generated with Claude Code