refactor(eq2db): base read helpers + dead code removal

[VortexUK]

Summary

Dedup + dead-code pass over the rearchitected eq2db catalogues (#144–#150).

Deduplication — _fetchall / _fetchone on BaseCatalogue

The single biggest repeated shape left was the read preamble — 24 copies of:

if not self.path.exists():
    return []
with sqlite3.connect(self.path) as conn:
    conn.row_factory = sqlite3.Row
    rows = conn.execute(...).fetchall()

Two base helpers now own the missing-file guard, Row factory, per-call open/close, and OperationalError graceful degradation. Converted: spells (all 5 reads), recipes (all 5), raids (both revision reads + the 4 ACT trigger/timer reads), zones catalogue-level reads, and aas (_query and total_max_points become thin wrappers). The zones active-record models keep their own connections — hydration needs the same conn for child fetches.

Two behaviour improvements fall out uniformly:

• unbuilt-DB resilience everywhere — previously only aas._query and zones.list_expansions caught OperationalError; now every read logs + degrades instead of 500ing on a provisioned-but-empty file.
• connections actually close — most reads used with sqlite3.connect(...) which commits but never closes (handle left to GC); the helpers close in a finally.

Dead code (zero references anywhere — code, tests, or docs)

• ZoneCatalogue.zone_count, Zone.find_by_id
• RaidCatalogue.find_zone_by_name / list_encounters_for_zone / list_zones_by_expansion / stats — the "for the future web routes" reads from the raids module's PoC era; the strategy routes ended up with their own targeted SQL and nothing ever called these.
• Their orphaned SQL blocks (raids.sql: the zone/encounter column fragments, 3 list queries, 5 stats queries; zones.sql: count_zones).

conftest

The seven duplicated DB_PATH + catalogue.path re-point pairs collapse into one loop — the next eq2db module can't forget the catalogue.path half.

Verification

1521 tests green, ruff + pyright clean. Live spot-checks on the dev backend across the converted read paths: character spells tab (find_by_ids/upgradeable_crcs), /api/spell-scroll (recipes find_by_spell), /api/aa/spell/{crc} (find_by_crc + aas caches).

🤖 Generated with Claude Code