Repository navigation
fix(lock): tidy the team lock policy follow-ups (#510) - #587
Merged
Merged
Conversation
- Signing out or resetting the vault drops the in-memory team lock policy, so a mobile logout (no reload) no longer keeps enforcing it. - The Members Security panel hides on a team the viewer cannot manage, instead of offering controls the server rejects with 403. - The audit log names team.lock_policy_set / team.lock_policy_removed in words, with the timeout and Lock vault requirement, and the action filter offers both. Filter labels now derive from one action list. - The Security panel warns when Immediately is combined with Require Lock vault: members' sessions close every time they leave Voltius. - The vault menu's Security policy item uses a named canSetLockPolicy capability instead of canRename. - The plan card lists the team lock policy as a Business feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the spec-3 review of the org lock policy (#581). Part of #510.
Changes
resetVault()clears the in-memory team lock policy before wiping the persisted copy. Mobile logout does not reload, so it used to keep enforcing the previous account's policy until restart. Not done inonSessionEnd: that also runs on Lock vault, and clearing there would drop enforcement after an offline unlock.team.lock_policy_set/team.lock_policy_removedrender as "set the lock policy (auto-lock: 15 minutes)", "… Lock vault required", "removed the lock policy", and the action filter offers both. The 34 hand-written filter entries become one action list whose labels come from the same key helperactionNameuses.canSetLockPolicyinstead ofcanRename(same rule: owner or Manage vault).New strings are in all six locales. The non-English ones are mine, not a native speaker's.
Verification
src/components/members,src/components/vault-admin,src/components/logs,src/i18n,src/services/vault.test.ts, AccountSection tests.tsc --noEmitis clean.voltius-server:sha-ff7968c, self-host mode, so Business): set and removed policies, and checked the audit rows, the action filter (filtering on "Lock policy removed" returns only that row), the warning and the plan card. Before/after screenshots on desktop and in the mobile shell were approved before commit.MembersPage.PendingPanel.test.tsx.Cons