Repository navigation
feat(auth): email the account owner when the master password changes - #112
Merged
Merged
Conversation
A device that is signed in can now change the password after an OS check, so the owner needs to hear about a change they did not make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful
PUT /v1/auth/password, the server emails the account owner. The email says the master password changed and when, and points to contact@voltius.app if they did not do it.The update now returns the email address and the undeliverable flag with
RETURNING, so no second query is needed. Sending runs in a spawned task, so the response never waits on Resend. Undeliverable addresses are skipped. A failed send is only logged.Why: VoltiusApp/voltius#629 lets a signed-in device change the password after an OS check (Windows Hello, Touch ID, polkit, Android biometrics) instead of the current password. The owner should hear about a change they did not make. This also covers changes made from the portal.
Without
RESEND_API_KEY(self-hosted, tests)send_via_resendlogs and returns, as it does for the other emails.The existing
update_passwordtests cover the query change. The full suite passes and clippy is clean.