Quickjs script args - #24
Merged
Merged
Conversation
Owner
Author
|
I'll come back and try again tomorrow seems to be a problem with the compilation. I was considering compiling via cmake similar to pycares and cyrx (cythonic monero crypto miner) |
* implement CMake and fix up tests * try labeling everything as static (linux) * use -fPIC on linux * maybe get rid of a section where there is header files? * do not use cmake on linux do this workaround instead * include header folder when compiling linux * please work * workaround all of linux with the old setup
* implement CMake and fix up tests * try labeling everything as static (linux) * use -fPIC on linux * maybe get rid of a section where there is header files? * do not use cmake on linux do this workaround instead * include header folder when compiling linux * please work * workaround all of linux with the old setup
…into quickjs-script-args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change was inspired by a suggestion made in #19 Which requests me to add a cli. Before we can reach that point we need to make a handful of changes to make that possible. There is still pleanty to be done and python module transportation has not been implemented yet due to the painful puzzle left in store as I need a way to hack in a function wrapper and get quickjs to remember where that function is and run it from python.
Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist