Repository navigation
test(pages): expect the enable notice's section key once - #606
Merged
Merged
Conversation
The scenario pages-enable-needs-build-type-or-source pinned the notice as the engine printed it when it prefixed every section line with its key, so the text read "pages: pages: declared ...". The engine now names a notice's section once, and a line that already leads with its key is left alone, so a run prints "pages: declared ..." and the pinned line no longer matched. The two changes landed minutes apart and each passed alone. Only the expectation moves: the scenario still forbids a POST and a PUT to the Pages endpoint and still pins the advice.
Contributor
File size check0 over a hard cap (fails), 6 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
Contributor
Member shape check16 finding(s).
Add the blank lines, make the comment one line directly above the item, comment every field or none, or list the path in 4 generated file(s) skipped. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the test-only notice expectation update.
No open issues 🎉
What changed in this PR
Updates a stale Pages end-to-end expectation to match the engine's notice formatting after #592 and #595 landed independently. Production behavior is unchanged.
Changes:
- Removes the duplicate
pages:prefix from the expected notice. - Keeps the no-POST/no-PUT checks, enablement advice, and permission explanation assertions intact.
| File | Description |
|---|---|
test/sections/pages/scenarios/pages-enable-needs-build-type-or-source.yml |
Corrects the expected notice to include the section key once. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Main's e2e job is red on this one scenario. Its pinned line is stale. What a run prints is right.
How
stdout_containsentry loses the doubled key.pages: pages: declared ...becomespages: declared ....Proof
bun test/e2e/run.ts --sections pagesends14/14 passed.git grep -n -P '::notice::([a-z_]+): \1: ' -- test docsprints one line onmain, this scenario's, and nothing on this branch.Technical details
underKeyinsrc/engine/orchestrate.tsleaves a line alone when it already leads with its section key followed by:,., or[.src/sections/pages/index.ts, unchanged.checks / e2ejob onmainatacb5ba40.test/sections/pages/scenarios/pages-enable-needs-build-type-or-source.yml.