-
Notifications
You must be signed in to change notification settings - Fork 1
SonarQube #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SmashingQuasar
wants to merge
4
commits into
main
Choose a base branch
from
dev/SmashingQuasar/sonarqube
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SonarQube #330
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d80a154
ci: Added Sonarqube automated scanning to Architectura.
SmashingQuasar 5346d04
ci: Moved sonar-project.properties at the top level.
SmashingQuasar 73d3b5f
chore: Resolved two small SonarQube issues.
SmashingQuasar 74d86f8
ci: Switch to SonarCloud.
SmashingQuasar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "src": "./src", | ||
| "exclude": [ | ||
| "mock", | ||
| "test" | ||
| ], | ||
| "extension": [ | ||
| ".mts" | ||
| ], | ||
| "reporter": [ | ||
| "html" | ||
| ], | ||
| "report-dir": "./coverage", | ||
| "skip-full": true, | ||
| "check-coverage": true, | ||
| "all": true, | ||
| "statements": 100, | ||
| "branches": 100, | ||
| "functions": 100, | ||
| "lines": 100 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "extension": [ | ||
| "mts" | ||
| ], | ||
| "node-option": [ | ||
| "loader=tsx" | ||
| ], | ||
| "spec": [ | ||
| "test/**/*.spec.mts" | ||
| ], | ||
| "timeout": 5000, | ||
| "parallel": true, | ||
| "checkLeaks": true, | ||
| "diff": true, | ||
| "forbidPending": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2024 VitruviusLabs | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import configurations from "../../eslint.config.mjs"; | ||
|
|
||
| export default configurations; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "name": "@vitruvius-labs/instrumenta", | ||
| "version": "0.1.0", | ||
| "description": "A package providing tools to work with the Architectura framework.", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "keywords": [], | ||
| "author": "Vitruvius Labs", | ||
| "contributors": [ | ||
| "Nicolas \"SmashingQuasar\" Lebacq" | ||
| ], | ||
| "license": "ISC", | ||
| "packageManager": "pnpm@10.10.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { extractInterfaceName } from "./utility/open-api/extract-interface-name.mjs"; | ||
| import { extractInterfaceProperties } from "./utility/open-api/extract-interface-properties.mjs"; | ||
| // import { interfaceToOpenAPISchema } from "./utility/open-api/interface-to-open-api-schema.mjs"; | ||
|
|
||
| const interfaceContent: string = ` | ||
| import type { SearchFragmentDateInterface } from "../../entity/auxiliary/search-fragment-date/definition/interface/search-fragment-date.interface.mjs"; | ||
|
|
||
| interface BaseSearchPayloadInterface | ||
| { | ||
| page?: number; | ||
| limit?: number; | ||
| uuids?: Array<string>; | ||
| createdAt?: SearchFragmentDateInterface; | ||
| } | ||
|
|
||
| export type { BaseSearchPayloadInterface }; | ||
| `; | ||
|
|
||
| const name: string | undefined = extractInterfaceName(interfaceContent); | ||
| const properties: Record<string, string> = extractInterfaceProperties(interfaceContent); | ||
| // const fullResult: string = interfaceToOpenAPISchema(interfaceContent); | ||
|
|
||
| console.debug(name); | ||
| console.debug(properties); | ||
| // console.debug(fullResult); |
6 changes: 6 additions & 0 deletions
6
...src/utility/open-api/interface/definition/interface/interface-instantiation.interface.mts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| interface InterfaceInstantiationInterface | ||
| { | ||
| content: string; | ||
| } | ||
|
|
||
| export type { InterfaceInstantiationInterface }; |
59 changes: 59 additions & 0 deletions
59
packages/instrumenta/src/utility/open-api/interface/interface.mts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import type { InterfaceInstantiationInterface } from "./definition/interface/interface-instantiation.interface.mjs"; | ||
|
|
||
| class Interface | ||
| { | ||
| private static readonly NameRegularExpression: RegExp = /interface\s+(?<name>\w+)\s*\{?/g; | ||
| private static readonly PropertiesRegularExpression: RegExp = /(?<property>[a-zA-Z]\w*)\??:\s*(?<type>[a-zA-Z][\w<>]*)/g; | ||
|
|
||
| private readonly contents: string; | ||
| private name: string | undefined; | ||
| private readonly properties: Record<string, string> = {}; | ||
|
|
||
| public constructor(parameters: InterfaceInstantiationInterface) | ||
| { | ||
| this.contents = parameters.content; | ||
| } | ||
|
|
||
| protected extractName(): void | ||
| { | ||
| const match: RegExpExecArray | null = Interface.NameRegularExpression.exec(this.contents); | ||
|
|
||
| if (match === null) | ||
| { | ||
| return undefined; | ||
| } | ||
|
|
||
| const name: string | undefined = match.groups?.["name"]; | ||
|
|
||
| Interface.NameRegularExpression.lastIndex = 0; | ||
|
|
||
| this.name = name; | ||
| } | ||
|
|
||
| protected extractProperties(): void | ||
| { | ||
| let match: RegExpExecArray | null = Interface.PropertiesRegularExpression.exec(this.contents); | ||
|
|
||
| if (match === null) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| while (match !== null) | ||
| { | ||
| const property: string | undefined = match.groups?.["property"]; | ||
| const type: string | undefined = match.groups?.["type"]; | ||
|
|
||
| if (property !== undefined && type !== undefined) | ||
| { | ||
| this.properties[property] = type; | ||
| } | ||
|
|
||
| match = Interface.PropertiesRegularExpression.exec(this.contents); | ||
| } | ||
|
|
||
| Interface.PropertiesRegularExpression.lastIndex = 0; | ||
| } | ||
| } | ||
|
|
||
| export { Interface }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "./build/esm", | ||
| "declarationDir": "./build/types", | ||
| "rootDir": "./src", | ||
| "declaration": true, | ||
| "declarationMap": false, | ||
| "removeComments": false, | ||
| "sourceMap": false, | ||
| "noEmit": false, | ||
| "listFiles": false, | ||
| "listEmittedFiles": false | ||
| }, | ||
| "include": [ | ||
| "./src" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": {}, | ||
| "include": [ | ||
| "./src", | ||
| "./test", | ||
| "./mock" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/tsconfig", | ||
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "allowSyntheticDefaultImports": true | ||
| }, | ||
| "include": [ | ||
| "./src", | ||
| "./test", | ||
| "./mock" | ||
| ], | ||
| "exclude": [ | ||
| "./node_modules" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "include": [ | ||
| ".", | ||
| "./**/.*", | ||
| "./**/*.json" | ||
| ], | ||
| "ts-node": { | ||
| "files": true, | ||
| "swc": true | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ruled against initializing properties outside the constructor.