Repository navigation
fix: send isRunning=false in stop() — empty PATCH body no longer stops build on backend 5.1.0+ - #118
Merged
Merged
Conversation
Contributor
Author
|
Hey @pashidlos, could you take a look when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we want to stop build, SDK sends
PATCH /builds/{id}with an empty body. Backend relied on a fallback that treated an empty body asisRunning = false:This was removed in Visual-Regression-Tracker/backend@a5da984 (#336, NestJS v11 upgrade), released in api-v5.1.0. Since then,
stop()is a no-op and builds stay in "running" state.Fix
request/ModifyBuildRequest(isRunning), mirroring backendModifyBuildDtostop()now sends{"isRunning":false}shouldStopBuildtest now asserts the request bodyBackward compatible with older backends (explicit
isRunning: falsewas always supported).