Repository navigation
feat(project-form): DINOv2 check under the rendering-noise filter - #441
Merged
Merged
Conversation
minNumber and maxNumber compare the whole part only, so 128.5 passed the form and the backend fell back to its default. minFloat and maxFloat compare the number as typed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
While the filter is on, each library's config offers "Check with DINOv2" and its threshold (0.01-2, the backend default 0.15 until edited), written as dinov2Check / dinov2Threshold into imageComparisonConfig and carried over when the library or VLM provider changes. The form asks GET /dinov2/status whether the server can run the check. With no service set up the switch cannot be turned on, as the backend would send every run the filter passes to review; a project saved with it on says so and can turn it off. A service that is set up but not answering gets a warning. A backend without the endpoint counts as having no service. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The project form's side of the DINOv2 check (Visual-Regression-Tracker/backend#431): a second look before the rendering-noise filter passes a run, which catches faint changes of content the blur misses (a missing light icon).
While "Ignore rendering noise" is on, every library's config form (pixelmatch, looks-same, odiff, VLM) offers "Check with DINOv2" and, while that is on, a "DINOv2 threshold" field (0.01–2, shows the backend default of 0.15 until edited). They write
dinov2Check/dinov2ThresholdintoimageComparisonConfigand are carried over when the library or VLM provider changes.Whether the server can run it
The form asks
GET /dinov2/status({ configured, available }):DINOV2_URLunset)Also
fix(project-form): the rendering-noise threshold usedminNumber/maxNumber, which compare the whole part only — 128.5 passed the form and the backend fell back to its default. NowminFloat/maxFloat(separate commit, with a test that fails on the old validators).Verification
dinov2Service).npm run lint0 errors,npm run typecheck,npm run buildclean.mockDinov2Status; request-body and availability tests inprojectList.spec.ts. In Docker the full suite ran 310/316 — the 6 failures (project list render, test-run grid, matching-variations screenshot) passed 116/116 twice when those files ran alone, the load flakiness also seen on master.screens.spec.ts: new entries "edit project dialog with the DINOv2 check on" and "edit project dialog on a server without DINOv2";edit-project-noise-filterchanges by the new switch under the threshold. Baselines generated in Docker, every changed PNG looked at.Merge order
After backend#431: this form needs
GET /dinov2/status. Against a backend without it, the check is simply not offered.🤖 Generated with Claude Code