Repository navigation
ci(docker): check out release tags explicitly and drop token persistence - #416
Merged
Merged
Conversation
- workflow_dispatch checks out refs/tags/<tag>, so a branch with the same name can't be published under a release version - persist-credentials: false keeps GITHUB_TOKEN out of .git/config, which is part of the build context - permissions: contents: read; pushes use the Docker Hub secrets Addresses CodeRabbit review on backend#412. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #412, addressing the two CodeRabbit findings on
.github/workflows/docker.yml:ref: ${{ inputs.tag }}. If a branch has the same name as the tag,actions/checkoutresolves it to the branch, so branch contents could be published under a release version. Manual runs now check outrefs/tags/<tag>(a missing tag fails instead).actions/checkoutwritesGITHUB_TOKENinto.git/config, and the api image builds withcontext: .(no.dockerignoreexcludes.git). Setpersist-credentials: falseandpermissions: contents: read; pushes authenticate with the Docker Hub secrets, notGITHUB_TOKEN.The same change is applied to the ui workflow in Visual-Regression-Tracker/frontend#431.
🤖 Generated with Claude Code