fix(voice): add service status validation, safe dictionary access, and fallback attributes in voice_status - #3
Open
Vishaaallll wants to merge 2 commits into
Open
Vishaaallll wants to merge 2 commits into
Vishaaallll wants to merge 2 commits into
Conversation
…ogging in voice_status in voice.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
voice_statusendpoint inods/extensions/services/dashboard-api/routers/voice.py:cfgobject type (isinstance(cfg, dict)) before evaluating health checks for Whisper, TTS, and LiveKit services.getattr(result, "status", "unknown")to safely extract service status from health check return objects.entry["status"]) ininstalled_healthywith safe dictionary.get()calls (entry.get("status")) andisinstance(entry, dict)type guards.configuredboolean metadata for downstream frontend rendering.Why It Is Useful
KeyError,AttributeError,TypeError) with graceful fallback status representations ("unavailable","not_configured").configuredflags to response dictionaries, enabling the UI to distinguish between unconfigured services and failed service health checks.Verification
pytest ods/extensions/services/dashboard-api/tests/ -k voice -v(8 passed).