fix(auth): validate integer expiry before computing hmac signature in session_signer.py - #2
Open
Vishaaallll wants to merge 2 commits into
Open
Vishaaallll wants to merge 2 commits into
Vishaaallll wants to merge 2 commits into
Conversation
…ects before computing hmac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-orders verification checks in
session_signer.verify()inods/extensions/services/dashboard-api/session_signer.py:expiry_stris a valid integer BEFORE computing the HMAC-SHA256 signature (_sign(payload)).(False, "malformed")immediately upon integer conversion failure.test_session_signer.pyasserting_sign()is never invoked when an invalid expiry token is passed.Why It Is Useful
hmac.new+ SHA256 hashing) when processing invalid or corrupted session tokens.Verification
pytest ods/extensions/services/dashboard-api/tests/test_session_signer.py -v(21 passed).