fix(templates): add input validation, callable checks, and cycle tracing in _runtime_dependency_order - #1
Open
Vishaaallll wants to merge 2 commits into
Open
Vishaaallll wants to merge 2 commits into
Vishaaallll wants to merge 2 commits into
Conversation
…der in templates.py
…ing in _runtime_dependency_order in templates.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strict input type validation and defensive error handling for service dependency resolution in
_runtime_dependency_order()inods/extensions/services/dashboard-api/routers/templates.py:service_idis a non-empty string.read_direct_depsparameter is callable and returns iterable collections (list,tuple,set).try...finallyblock to guarantee_visitingset cleanup even when exceptions occur.service_a -> service_b -> service_a).Why It Is Useful
_visitingstate so subsequent requests do not fail due to lingering stack frames when errors occur during dependency resolution.Verification
pytest ods/extensions/services/dashboard-api/tests/test_templates.py -v(31 passed).