Repository navigation
fix: read the Geode vault path from injected settings - #9
Merged
Merged
Conversation
Lathe Bar.qml injectProps assigns target.settings = moduleSettings only
when the widget declares a settings property; it never assigns
vaultPath. BarWidget now declares property var settings: ({}) and
derives vaultPath from settings.vaultPath (the manifest schema key).
onSettingsChanged calls rerun(), so a host-assigned settings object
starts the run. Empty or missing settings.vaultPath keeps the
empty-vault failed status.
Kept: no onFailedToStart, onExited refresh(code, collector.text),
running-still-false folds Model.statusFromRun(127, "", "").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BarWidget.qmlnow hasproperty var settings.vaultPathis derived fromsettings.vaultPath, which is what latheBar.qmlinjectProps()assigns. A host-assigned settings object callsrerun().settings.vaultPathstays the empty-vault failure. A set path still runsModel.listArgs.onFailedToStart,onExitedusescollector.text, and a process that staysrunning: falseusesModel.statusFromRun(127, "", "").e6217f3.Test plan
settings, derivedvaultPath,onSettingsChanged: rerun()testscheck green before merge