Skip to content

test: lock the Quickshell 0.3.0 bar fold - #8

Merged
VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status
Sep 24, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Owner

Summary

  • tests/bar_fold.sh locks the Quickshell 0.3.0 bar fold in BarWidget.qml.
  • The clean tree exits 0. The test exits non-zero if the file contains onFailedToStart or geodeRun.exitCode, if onExited does not pass collector.text to refresh, or if the missing-binary call Model.statusFromRun(127, "", "") is absent.
  • A comment that says Process has no exitCode property stays allowed. QA is grading df124eb.

Test plan

  • Clean bash tests/bar_fold.sh exits 0
  • Injected onFailedToStart and geodeRun.exitCode exit non-zero
  • GitHub tests check green before merge

PR #7 fixed BarWidget.qml for Quickshell 0.3.0, but nothing in tests/ locked
that fold, so a later edit could put onFailedToStart back with the clean tree
still green. tests/bar_fold.sh scans BarWidget.qml as raw text and fails when:

- the file contains onFailedToStart (Process emits no such signal),
- the file contains geodeRun.exitCode (Process exposes no exitCode property;
  a comment that merely says exitCode is allowed - the read is what fails),
- the onExited binding does not call refresh with collector.text in the same
  call (scoped to that binding, so a mention elsewhere cannot satisfy it;
  whitespace and line-break tolerant),
- the file no longer calls Model.statusFromRun(127, "", ""), the
  missing-binary shape for a run that never emits exited.

No geode subprocess, no socket, no Omarchy, no QML runtime: grep + awk over one
file. ci.yml already runs tests/*.sh under set -e.
@VirtualMachinist
VirtualMachinist merged commit 804fb4d into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant