Repository navigation
test: lock the Quickshell 0.3.0 bar fold - #8
Merged
Merged
Conversation
PR #7 fixed BarWidget.qml for Quickshell 0.3.0, but nothing in tests/ locked that fold, so a later edit could put onFailedToStart back with the clean tree still green. tests/bar_fold.sh scans BarWidget.qml as raw text and fails when: - the file contains onFailedToStart (Process emits no such signal), - the file contains geodeRun.exitCode (Process exposes no exitCode property; a comment that merely says exitCode is allowed - the read is what fails), - the onExited binding does not call refresh with collector.text in the same call (scoped to that binding, so a mention elsewhere cannot satisfy it; whitespace and line-break tolerant), - the file no longer calls Model.statusFromRun(127, "", ""), the missing-binary shape for a run that never emits exited. No geode subprocess, no socket, no Omarchy, no QML runtime: grep + awk over one file. ci.yml already runs tests/*.sh under set -e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/bar_fold.shlocks the Quickshell 0.3.0 bar fold inBarWidget.qml.onFailedToStartorgeodeRun.exitCode, ifonExiteddoes not passcollector.texttorefresh, or if the missing-binary callModel.statusFromRun(127, "", "")is absent.exitCodeproperty stays allowed. QA is gradingdf124eb.Test plan
bash tests/bar_fold.shexits 0onFailedToStartandgeodeRun.exitCodeexit non-zerotestscheck green before merge