Skip to content

fix: load the Geode bar on Quickshell 0.3.0 - #7

Merged
VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status
Sep 24, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Owner

Summary

  • BarWidget.qml no longer uses onFailedToStart, which Quickshell 0.3.0 rejects, so the bar can load.
  • onExited is the only stdout fold: refresh(code, collector.text).
  • If running stays false after start, the status is the missing-binary result from Model.statusFromRun(127, "", ""). A set vault path no longer stays on the empty-vault message.
  • QA page is in flight for 86faaa5. Push CI must be green before merge.

Test plan

  • Source grade: no onFailedToStart, onExited uses collector.text, still-false running sets the missing-binary status
  • GitHub tests check green before merge
  • Lathe re-probe: the bar instantiates and records ok: false with the missing-binary reason

Quickshell 0.3.0 Process has no onFailedToStart property; assigning it
refused to load the widget (non-existent property). Removed.

A missing geode binary never emits exited: the run stays running=false
with pid null. rerun() now checks the flag after running=true and folds
Model.statusFromRun(127, "", "") so a set vault path shows the
missing-binary reason.

onExited stays the only exit fold: refresh(code, collector.text). No
exitCode property is read.
@VirtualMachinist
VirtualMachinist merged commit c795e36 into main Sep 24, 2026
2 checks passed
VirtualMachinist added a commit that referenced this pull request Sep 24, 2026
PR #7 fixed BarWidget.qml for Quickshell 0.3.0, but nothing in tests/ locked
that fold, so a later edit could put onFailedToStart back with the clean tree
still green. tests/bar_fold.sh scans BarWidget.qml as raw text and fails when:

- the file contains onFailedToStart (Process emits no such signal),
- the file contains geodeRun.exitCode (Process exposes no exitCode property;
  a comment that merely says exitCode is allowed - the read is what fails),
- the onExited binding does not call refresh with collector.text in the same
  call (scoped to that binding, so a mention elsewhere cannot satisfy it;
  whitespace and line-break tolerant),
- the file no longer calls Model.statusFromRun(127, "", ""), the
  missing-binary shape for a run that never emits exited.

No geode subprocess, no socket, no Omarchy, no QML runtime: grep + awk over one
file. ci.yml already runs tests/*.sh under set -e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant