Repository navigation
docs: drop forbidden token strings from Model.js comments - #5
Merged
Merged
Conversation
VirtualMachinist
added a commit
that referenced
this pull request
Sep 24, 2026
Verification rejected the previous revision: it stripped `//` comments before matching, so a comment containing GEODE_TOKEN would still exit 0. - Drop the comment stripper. Model.js, BarWidget.qml, manifest.json and README.md are now scanned as raw text, so a red-line string fails wherever it appears -- source, JSON, prose, or comment. - The clean tree stays green because the comment cleanup (PR #5) removed those substrings from Model.js's comments; a comment that reintroduces `GEODE_TOKEN` fails the tree again. - Unchanged: case-insensitive fixed-string match on agent serve / GTOK / GEODE_TOKEN / tui --token / agent token; a missing guarded file exits 1 so a rename cannot leave the guard vacuously green; cwd-independent; no geode subprocess, no socket, no Omarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model.jscomments no longer containagent serve,GTOK,GEODE_TOKEN,tui --token, oragent token.listArgsis unchanged:["geode", "list", vaultPath, "--output", "json"].foundry/geode/evidence/omarchy/g0c-qa.md— GEODE OMARCHY G0c QA 578d305 PASS. Push CI on this sha already succeeded.Test plan
Model.jsandlistArgsreturn linecirun 35942371133 successtestscheck green before merge