Skip to content

docs: drop forbidden token strings from Model.js comments - #5

Merged
VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status
Sep 24, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Owner

Summary

  • Model.js comments no longer contain agent serve, GTOK, GEODE_TOKEN, tui --token, or agent token.
  • listArgs is unchanged: ["geode", "list", vaultPath, "--output", "json"].
  • QA: foundry/geode/evidence/omarchy/g0c-qa.md — GEODE OMARCHY G0c QA 578d305 PASS. Push CI on this sha already succeeded.

Test plan

  • Substring scan of Model.js and listArgs return line
  • Push ci run 35942371133 success
  • Pull request tests check green before merge

@VirtualMachinist
VirtualMachinist merged commit 6d041a9 into main Sep 24, 2026
2 checks passed
VirtualMachinist added a commit that referenced this pull request Sep 24, 2026
Verification rejected the previous revision: it stripped `//` comments before
matching, so a comment containing GEODE_TOKEN would still exit 0.

- Drop the comment stripper. Model.js, BarWidget.qml, manifest.json and
  README.md are now scanned as raw text, so a red-line string fails wherever it
  appears -- source, JSON, prose, or comment.
- The clean tree stays green because the comment cleanup (PR #5) removed those
  substrings from Model.js's comments; a comment that reintroduces
  `GEODE_TOKEN` fails the tree again.
- Unchanged: case-insensitive fixed-string match on agent serve / GTOK /
  GEODE_TOKEN / tui --token / agent token; a missing guarded file exits 1 so a
  rename cannot leave the guard vacuously green; cwd-independent; no geode
  subprocess, no socket, no Omarchy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant