Skip to content

fix(model): read geode 1.2.1 list NDJSON - #13

Merged
VirtualMachinist merged 1 commit into
mainfrom
fix/list-ndjson
Oct 18, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
fix/list-ndjson

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Owner

Summary

Fixes #12. statusFromRun reads geode-cli 1.2.1 list --output json as one geode.event.v1 document per line, and still accepts a single JSON document from an older binary.

entries is the list of event path strings. The summary files count is not stored there. Exit 0 with an ok: true summary returns ok: true. A non-zero exit stays a failure. Exit 127 keeps the 1.2.1 install sentence.

tests/list_ndjson.sh loads Model.js in node. No product repo change. The install pin stays geode-cli 1.2.1.

Test plan

  • bash tests/list_ndjson.sh covers the issue's two-line sample, a one-document fallback, an empty vault, and the failure shapes
  • bash tests/no_agent_token_surface.sh still passes
  • GitHub Actions tests is green
  • QA grades 4619075e5115d2f740974fc7e0058259f6eed6b2

geode list --output json on 1.2.1 prints one geode.event.v1 document per
line, which the whole-stdout JSON.parse rejected. statusFromRun now parses
the whole text as one document when it can (older binaries) and otherwise
one document per non-empty line. Each event path is collected into
entries as a string; the summary files count is never stored there. ok
is true only for exit 0 with an ok:true summary. Exit 127 keeps the
install sentence.

tests/list_ndjson.sh loads Model.js in node and checks the issue sample,
a single document, an empty vault, and the failure shapes.

Fixes #12

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@VirtualMachinist
VirtualMachinist merged commit da3dd3b into main Oct 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar widget fails on geode 1.2.x NDJSON output — 'geode list printed unparsable JSON'

1 participant