Repository navigation
fix(model): read geode 1.2.1 list NDJSON - #13
Merged
Merged
Conversation
geode list --output json on 1.2.1 prints one geode.event.v1 document per line, which the whole-stdout JSON.parse rejected. statusFromRun now parses the whole text as one document when it can (older binaries) and otherwise one document per non-empty line. Each event path is collected into entries as a string; the summary files count is never stored there. ok is true only for exit 0 with an ok:true summary. Exit 127 keeps the install sentence. tests/list_ndjson.sh loads Model.js in node and checks the issue sample, a single document, an empty vault, and the failure shapes. Fixes #12 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12.
statusFromRunreads geode-cli 1.2.1list --output jsonas onegeode.event.v1document per line, and still accepts a single JSON document from an older binary.entriesis the list of eventpathstrings. The summaryfilescount is not stored there. Exit 0 with anok: truesummary returnsok: true. A non-zero exit stays a failure. Exit 127 keeps the 1.2.1 install sentence.tests/list_ndjson.shloadsModel.jsin node. No product repo change. The install pin staysgeode-cli1.2.1.Test plan
bash tests/list_ndjson.shcovers the issue's two-line sample, a one-document fallback, an empty vault, and the failure shapesbash tests/no_agent_token_surface.shstill passestestsis green4619075e5115d2f740974fc7e0058259f6eed6b2