Repository navigation
fix: read settings.vaultPath inside the bar run - #10
Merged
Merged
Conversation
injectProps assigns settings before the vaultPath binding flushes, so rerun() read the stale "" and stayed on the empty-vault status. vaultPathNow() reads settings.vaultPath directly; rerun(), refresh(), and the click launcher call it instead of touching the property. No Qt.callLater, no new signal. Kept: onExited refresh(code, collector.text); still-false running folds Model.statusFromRun(127, "", ""); no onFailedToStart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rerun(),refresh(), and the click launcher callvaultPathNow(), which readssettings.vaultPathdirectly.onSettingsChangedno longer depends on thevaultPathbinding having flushed. A hostsettingsassignment is visible insidererun().onFailedToStart,onExitedusescollector.text, and a process that staysrunning: falseusesModel.statusFromRun(127, "", "").3ef371f.Test plan
vaultPathNow()used by rerun, refresh, and clicktestscheck green before mergesettings; the reason is the missing-binary string, not the empty-vault string