Skip to content

fix: read settings.vaultPath inside the bar run - #10

Merged
VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status
Sep 24, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
feat/omarchy-status

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Owner

Summary

  • rerun(), refresh(), and the click launcher call vaultPathNow(), which reads settings.vaultPath directly.
  • onSettingsChanged no longer depends on the vaultPath binding having flushed. A host settings assignment is visible inside rerun().
  • The Quickshell 0.3.0 fold stays: no onFailedToStart, onExited uses collector.text, and a process that stays running: false uses Model.statusFromRun(127, "", "").
  • QA is grading 3ef371f.

Test plan

  • Source grade: vaultPathNow() used by rerun, refresh, and click
  • GitHub tests check green before merge
  • Lathe: create the bar with no props, then assign settings; the reason is the missing-binary string, not the empty-vault string

injectProps assigns settings before the vaultPath binding flushes, so
rerun() read the stale "" and stayed on the empty-vault status.
vaultPathNow() reads settings.vaultPath directly; rerun(), refresh(),
and the click launcher call it instead of touching the property. No
Qt.callLater, no new signal.

Kept: onExited refresh(code, collector.text); still-false running folds
Model.statusFromRun(127, "", ""); no onFailedToStart.
@VirtualMachinist
VirtualMachinist merged commit 6c5d6d7 into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant