Repository navigation
Fix iOS photo-permission crash, editor reorder staleness, .tex email escaping - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the safe, verifiable findings from
REVIEW.md.H1 — iOS signature picker crash
ios/Runner/Info.plistgainsNSPhotoLibraryUsageDescription. Without it, tapping Add signature on iOS is a hard crash (SIGABRT), not a permission prompt.M1 — editor fields show stale text after reordering / deleting an entry
EditorFieldseeds aTextFormFieldfrominitialValueonce and_EntryFramehad no key, so reordering an Employment/Skills/Education/Projects/References entry (or deleting a middle one) left the form fields showing the previous entry's text — the model was fine, the UI was not._EntryFramenow takes akey; every call site passesObjectKey(entry)so the field subtree moves with its model object.StringListEditor(bullets, paragraphs, soft skills) is now stateful with oneTextEditingControllerper row, reordered/inserted/removed in lock-step with the list;didUpdateWidgetonly resyncs on a genuine external replace.test/string_list_editor_test.dart(3 widget tests) — first widget-level coverage in the repo.M2 (email) —
.texexport breaks on emails with_The three
.textemplates now wrap the visible address in\nolinkurl{}(\href{mailto:<<EMAIL>>}{\nolinkurl{<<EMAIL>>}}), sojane_doe@example.comno longer emits a bare_in text mode. URL\hreftargets are already read verbatim by hyperref; the remaining URL-display cases use escaped labels.L8 — Android launcher label
android:labelresume_generator→Resume Generator(matches iOSCFBundleDisplayName).flutter analyzeclean · 27 tests pass (was 24).🤖 Generated with Claude Code