Skip to content

Fix iOS photo-permission crash, editor reorder staleness, .tex email escaping - #4

Merged
Vinald merged 1 commit into
mainfrom
fix/safe-bugs
Sep 9, 2026
Merged

Vinald merged 1 commit into
mainfrom
fix/safe-bugs

Conversation

@Vinald

@Vinald Vinald commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Fixes the safe, verifiable findings from REVIEW.md.

H1 — iOS signature picker crash

ios/Runner/Info.plist gains NSPhotoLibraryUsageDescription. Without it, tapping Add signature on iOS is a hard crash (SIGABRT), not a permission prompt.

M1 — editor fields show stale text after reordering / deleting an entry

EditorField seeds a TextFormField from initialValue once and _EntryFrame had no key, so reordering an Employment/Skills/Education/Projects/References entry (or deleting a middle one) left the form fields showing the previous entry's text — the model was fine, the UI was not.

  • _EntryFrame now takes a key; every call site passes ObjectKey(entry) so the field subtree moves with its model object.
  • StringListEditor (bullets, paragraphs, soft skills) is now stateful with one TextEditingController per row, reordered/inserted/removed in lock-step with the list; didUpdateWidget only resyncs on a genuine external replace.
  • Letter placeholder fields keyed by name.
  • New test/string_list_editor_test.dart (3 widget tests) — first widget-level coverage in the repo.

M2 (email) — .tex export breaks on emails with _

The three .tex templates now wrap the visible address in \nolinkurl{} (\href{mailto:<<EMAIL>>}{\nolinkurl{<<EMAIL>>}}), so jane_doe@example.com no longer emits a bare _ in text mode. URL \href targets are already read verbatim by hyperref; the remaining URL-display cases use escaped labels.

L8 — Android launcher label

android:label resume_generator → Resume Generator (matches iOS CFBundleDisplayName).

flutter analyze clean · 27 tests pass (was 24).

🤖 Generated with Claude Code

@Vinald
Vinald merged commit a8f0e0c into main Sep 9, 2026
2 checks passed
@Vinald
Vinald deleted the fix/safe-bugs branch September 9, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant