Repository navigation
Release polish: app icon/splash, texUrl escaping, widget test coverage - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gaps from a full project review before calling v1 buttoned up:
#0000FF"R" monogram in EB GaramondBold, matching the in-app look) via
flutter_launcher_icons/flutter_native_splash, replacing the stock Flutter logo. Bumpedpubspec.yamlversion to1.1.0+2to match thev1.1tag.texUrl()percent-encodes#/%inPORTFOLIO_URL/GITHUB_URL/LINKEDIN_URLbefore they go into\href{...}, closing the documented gapwhere either character could break the generated
.tex.SettingsScreen,PreviewScreen,LatexEditorScreen,PdfCombinerScreen,ExportSheet,contact_section.dart. 53 tests total (up from 38), plus twonew testing-seam gotchas documented in the README/test comments (an asset
load that only resolves reliably in the first
testWidgetsper file/isolate,and a page taller than the default test surface).
flutter analyzeclean, all 53 tests pass, bothflutter build apk --debugand
flutter build ios --release --no-codesignsucceed with the new assets.