Skip to content

Add deep code review document - #1

Merged
Vinald merged 1 commit into
mainfrom
docs/code-review
Sep 9, 2026
Merged

Vinald merged 1 commit into
mainfrom
docs/code-review

Conversation

@Vinald

@Vinald Vinald commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Adds REVIEW.md: a detailed review of the app on main.

What's in it

  • High (1): iOS signature picker crashes — Info.plist is missing NSPhotoLibraryUsageDescription.
  • Medium (3): editor fields show stale text after reordering an entry; .tex export emits invalid LaTeX for emails/URLs with special characters; signature image is trusted to be a decodable PNG/JPEG.
  • Low (12): settings written to disk per keystroke, "New resume" pre-filled with the whole seed CV, controller leak in rename dialog, preview page-format selector is a no-op, LaTeX editor edits silently discarded, empty References section renders 4 different ways, temp-filename collisions, Android launcher label is the raw package name, leftover Flutter-template web metadata, no zone error handling, double directory scan on startup, combiner re-reads file per rebuild.
  • Info (9): no widget/integration tests, model equality, debug-signed release APK, stock lints, assets/fonts/ declaration, fontawesome5-vs-6 doc mismatch, misplaced // ignore, com.vinald.* identifiers, untracked devtools_options.yaml.

Each finding has a file:line anchor, a concrete failure scenario and a suggested fix. No code changes in this PR.

Follow-up PRs: chore/anonymize-seed-data, docs/project-documentation, fix/safe-bugs.

🤖 Generated with Claude Code

@Vinald
Vinald merged commit 07af270 into main Sep 9, 2026
2 checks passed
@Vinald
Vinald deleted the docs/code-review branch September 9, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant