fix: preserve Zenodo archive extraction layout - #19
lfvasconcelos wants to merge 1 commit into
Conversation
Extract relative to the working directory so archives that already contain the data/010_eurostat_tables prefix do not create a duplicated path. Add a regression test for that layout. Co-authored-by: Oliver Reiter <reiter@wiiw.ac.at>
c541ca1 to
237cabc
Compare
|
Rebased onto current Why the earlier work did not fully close this. The
Every downstream reader looks under This PR restores that behavior and adds a regression test that builds a fixture archive with the real prefix and asserts the extracted path. Two things worth flagging for review:
|
Summary
unzipbehaviordata/010_eurostat_tables/prefixContext
PR #12 identified that the system
unzipcommand was not portable to Windows. The alternativecrossplattform-zipbranch fixed the portability issue withp7zip_jll, and commitebfb7f4was subsequently tested successfully on Windows.mastercurrently contains the earlier commit704c5db, which passes-odata/010_eurostat_tablesto 7-Zip. Because the Zenodo archive already contains that directory prefix, extraction producesdata/010_eurostat_tables/data/010_eurostat_tables/...and downstream readers cannot find the files.This change applies the extraction behavior from
ebfb7f4and adds a regression test for the actual archive layout.Validation
CalibrateBeforeITpackage load and precompilation: passedtest/test_download_function.jl: 16/16 tests passed, including the regression fixture containingdata/010_eurostat_tables/payload.txtgit diff --check upstream/master...HEAD: passed