Skip to content

renamed vmbackup and vmrestore ports#2085

Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
rename-backup-restore-port-names
Open

renamed vmbackup and vmrestore ports#2085
AndrewChubatiuk wants to merge 1 commit intomasterfrom
rename-backup-restore-port-names

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 21, 2026

Summary by cubic

Renamed vmbackup and vmrestore container port names to avoid collisions with vmsingle/vmstorage ports and fix Kubernetes validation/service issues. Ports now have unique names to prevent conflicts.

  • Bug Fixes

    • VMBackupManager port name: http-backup (was http)
    • VMRestore port name: http-restore (was http)
    • Applies to vmcluster and vmsingle where duplicate port names were not allowed.
  • Migration

    • Update any Service/Ingress/probes that reference these containers by port name to use http-backup and http-restore instead of http.
    • No action needed if targeting ports by number.

Written for commit 3d964cd. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:60">
P1: Custom agent: **Changelog Review Agent**

This changelog entry is missing the mandatory issue/PR reference link required by the changelog structure (Required structure §4: References). Add a `See [#...](...)` link to the related issue or PR.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread docs/CHANGELOG.md
* BUGFIX: [vmdistributed](https://docs.victoriametrics.com/operator/resources/vmdistributed/): use default stub, when no VMAuth backends are available
* BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): use volume from spec.volumes as persistent queue volume if its name is `persistent-queue-data`, previously emptyDir was mounted. See [#1677](https://github.com/VictoriaMetrics/operator/issues/1677).
* BUGFIX: [vmcluster](https://docs.victoriametrics.com/operator/resources/vmcluster/): use volume from spec.vmstorage.volumes and spec.vmselect.volumes as data and cache volumes if its name is `vmstorage-db` and `vmselect-cachedir` respectively. See [#784](https://github.com/VictoriaMetrics/operator/issues/784).
* BUGFIX: [vmcluster](https://docs.victoriametrics.com/operator/resources/vmcluster/) and [vmsingle](https://docs.victoriametrics.com/operator/resources/vmsingle/): renamed vmbackup and vmrestore port names, before they had identical to storage/single port names, which is not allowed.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Custom agent: Changelog Review Agent

This changelog entry is missing the mandatory issue/PR reference link required by the changelog structure (Required structure §4: References). Add a See [#...](...) link to the related issue or PR.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 60:

<comment>This changelog entry is missing the mandatory issue/PR reference link required by the changelog structure (Required structure §4: References). Add a `See [#...](...)` link to the related issue or PR.</comment>

<file context>
@@ -57,6 +57,7 @@ aliases:
 * BUGFIX: [vmdistributed](https://docs.victoriametrics.com/operator/resources/vmdistributed/): use default stub, when no VMAuth backends are available
 * BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): use volume from spec.volumes as persistent queue volume if its name is `persistent-queue-data`, previously emptyDir was mounted. See [#1677](https://github.com/VictoriaMetrics/operator/issues/1677).
 * BUGFIX: [vmcluster](https://docs.victoriametrics.com/operator/resources/vmcluster/): use volume from spec.vmstorage.volumes and spec.vmselect.volumes as data and cache volumes if its name is `vmstorage-db` and `vmselect-cachedir` respectively. See [#784](https://github.com/VictoriaMetrics/operator/issues/784).
+* BUGFIX: [vmcluster](https://docs.victoriametrics.com/operator/resources/vmcluster/) and [vmsingle](https://docs.victoriametrics.com/operator/resources/vmsingle/): renamed vmbackup and vmrestore port names, before they had identical to storage/single port names, which is not allowed.
 
 ## [v0.68.1](https://github.com/VictoriaMetrics/operator/releases/tag/v0.68.1)
</file context>
Fix with Cubic

@AndrewChubatiuk AndrewChubatiuk force-pushed the rename-backup-restore-port-names branch from acaf423 to 3d964cd Compare April 21, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant