Open
Conversation
eec12a2 to
af8d34d
Compare
0b5c04d to
5b6f1eb
Compare
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/operatorhub.yaml">
<violation number="1" location=".github/workflows/operatorhub.yaml:88">
P1: `PREV_CATALOG` is used without a guaranteed value, so first-time catalog generation can fail when no existing `catalog.yaml` is present.</violation>
</file>
<file name="Makefile">
<violation number="1" location="Makefile:299">
P2: Avoid fixed `/tmp/vm-*.{txt,yaml}` filenames in recipes; they can race across concurrent runs and corrupt generated catalogs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| $(YQ) -i '.annotations."com.redhat.openshift.versions" = "v4.12-v4.21"' \ | ||
| bundle/$(VERSION)/metadata/annotations.yaml | ||
| mkdir -p bundle/$(VERSION)/catalog-templates catalog/latest | ||
| $(YQ) '.entries[] | select(.schema == "olm.channel") | .entries[] | select(.name != "victoriametrics-operator.v$(VERSION)") | .name' config/manifests/catalog-templates/latest.yaml > /tmp/vm-prev-names.txt |
Contributor
There was a problem hiding this comment.
P2: Avoid fixed /tmp/vm-*.{txt,yaml} filenames in recipes; they can race across concurrent runs and corrupt generated catalogs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Makefile, line 299:
<comment>Avoid fixed `/tmp/vm-*.{txt,yaml}` filenames in recipes; they can race across concurrent runs and corrupt generated catalogs.</comment>
<file context>
@@ -283,25 +283,63 @@ build-installer: manifests generate kustomize ## Generate a consolidated YAML wi
$(YQ) -i '.annotations."com.redhat.openshift.versions" = "v4.12-v4.21"' \
bundle/$(VERSION)/metadata/annotations.yaml
+ mkdir -p bundle/$(VERSION)/catalog-templates catalog/latest
+ $(YQ) '.entries[] | select(.schema == "olm.channel") | .entries[] | select(.name != "victoriametrics-operator.v$(VERSION)") | .name' config/manifests/catalog-templates/latest.yaml > /tmp/vm-prev-names.txt
+ $(YQ) '.entries[] | select(.schema == "olm.channel") | .entries[] | select(.name != "victoriametrics-operator.v$(VERSION)") | .replaces | select(.)' config/manifests/catalog-templates/latest.yaml > /tmp/vm-prev-replaces.txt
+ PREV_HEAD=$$(grep -Fxvf /tmp/vm-prev-replaces.txt /tmp/vm-prev-names.txt | head -1); \
</file context>
AndrewChubatiuk
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup release scripts and manifests, move most of the logic into Makefile.
See https://redhat-openshift-ecosystem.github.io/operator-pipelines/users/fbc_onboarding/ for FBC details.
Fixes #2037
TODO:
Generated 0.68.4 bundle using this Makefile and its identical to the generated catalog bundle
Now defined in the file