Repository navigation
app/vmui: add a span volume by service chart to Trace Explorer - #275
arturminchukov wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 45 files
Click Fix with cubic on a comment, or reply @cubic-dev-ai fix this, and cubic writes the fix.
Turn on auto-fix | Re-trigger cubic
122a63a to
91a8379
Compare
|
Hi Artur if it's ready for review you can update the status. I saw that it's draft for now but requested for a review. |
Yeah, it's my mistake to add reviewers before it's ready for review. I will update the status when I finish fixing the comments from a cubic, and it will be ready for review. |
91a8379 to
0a4f5f7
Compare
There was a problem hiding this comment.
All reported issues were addressed across 46 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
The new UI dropped the hits chart from the old logs-style page, so there was no way to see ingestion spikes or how spans split across services. The chart comes back as a Heatmap / Volume tab above the traces table, with charts registered in one list so adding another one is local.
0a4f5f7 to
f1c4d52
Compare
|
what about making tab name more generic, not |
|
As far as I remember this bar chart was for streams. @AndrewChubatiuk 's suggestion sounds good to me, but it's fine to keep the design in this pull request and iterate to customizable (stream) fields. I'll leave the planning stuffs to @arturminchukov . And it's also fine to not adopt it. I wish to provide useful but clean features on VTUI and leave other complex visualization to Grafana. WDYT? |
Signed-off-by: Zhu Jiekun <jiekun@victoriametrics.com>
Let's keep this PR as is. I think it is already too complex to review. So it will be better to do it in a separate PR if we want to implement it. |
3 participants
Related issue: #263
Returned hits bar chart. Now the visualization section has a tab menu to navigate between different types of charts.
