Repository navigation
.github/workflows/vmui.yml: remove eslint annotation action - #224
Merged
jiekun merged 1 commit intoSep 30, 2026
Conversation
rudransh-shrivastava
force-pushed
the
rudransh/remove-eslint-annotate-action
branch
from
July 23, 2026 09:58
35c19c4 to
0ab528e
Compare
rudransh-shrivastava
marked this pull request as ready for review
July 23, 2026 10:01
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
Author
|
Hi @Loori-R |
jiekun
approved these changes
Sep 28, 2026
Member
|
Thank you for the contribution! |
Member
Author
|
Hi @jiekun |
Member
Author
|
I will rebase. |
rudransh-shrivastava
marked this pull request as draft
September 30, 2026 06:27
Remove the unmaintained third-party `ataylorme/eslint-annotate-action` from the vmui workflow in order to reduce supply-chain risk. The `make vmui-lint` command still fails CI on lint errors. Printing ESLint errors in the workflow logs should be enough for blocking pull requests with lint errors. See the alternatives considered and why this was removed: VictoriaMetrics/VictoriaMetrics#11259 (comment) Signed-off-by: Rudransh Shrivastava <rudransh@victoriametrics.com>
rudransh-shrivastava
force-pushed
the
rudransh/remove-eslint-annotate-action
branch
from
September 30, 2026 06:31
42ea0e4 to
50227e6
Compare
rudransh-shrivastava
marked this pull request as ready for review
September 30, 2026 06:32
jiekun
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Remove the unmaintained third-party
ataylorme/eslint-annotate-actionfrom the vmui workflow in order to reduce supply-chain risk.The
make vmui-lintcommand still fails CI on lint errors. Printing ESLint errors in the workflow logs should be enough for blocking pull requests with lint errors.See the alternatives considered and why this was removed: VictoriaMetrics/VictoriaMetrics#11259 (comment)
cc: @arkid15r
Ref: ataylorme/eslint-annotate-action
Checklist
The following checks are mandatory: