Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While editing an inline-rendered table cell, the caret snaps back to the
start of the cell whenever the debounced
updateBlockre-renders the blockrenderer — worst when the cell is empty. (Closes #3)
Root cause
Cells were rendered with a React
childrenprop. EveryupdateBlockechore-run reconciled the tree against freshly-written content; React's direct
text-child fast path (
setTextContent) rewrote the livecontenteditabletext (empty cells rebuild the text child via
node.textContent = ''),resetting the caret. The old "identical text is a no-op" assumption broke
for empty cells.
Fix
Render
<th>/<td>WITHOUT achildrenprop so React never owns cell text(
shouldSetTextContentstays false — no moresetTextContentduringre-render). Initial text is applied once via a cell ref (
syncCellText),guarded by a
textContentcomparison so the normal echo re-render is ano-op and the caret is left untouched. Structural ops still overwrite
genuinely different text;
resumePinnedToolbarre-anchors the caret.Verification
syncCellText(no-op on equal text, write/clear/overwrite,null-safety) —
npm test10/10 pass.npm run buildsucceeds.while clearing a cell.