Skip to content

128-revival-add-more-tests#132

Merged
VianneyMI merged 9 commits into
mainfrom
128-revival-add-more-tests
Jun 4, 2025
Merged

128-revival-add-more-tests#132
VianneyMI merged 9 commits into
mainfrom
128-revival-add-more-tests

Conversation

@VianneyMI
Copy link
Copy Markdown
Owner

No description provided.

@VianneyMI VianneyMI linked an issue Jun 1, 2025 that may be closed by this pull request
6 tasks
# -----------------------------------------
@staticmethod
def Autocomplete(**kwargs)->Autocomplete:
def Autocomplete(**kwargs) -> Autocomplete:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Compound(**kwargs)->Compound:
def Compound(**kwargs) -> Compound:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Equals(**kwargs)->Equals:
def Equals(**kwargs) -> Equals:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Exists(**kwargs)->Exists:
def Exists(**kwargs) -> Exists:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Facet(**kwargs)->Facet:
def Facet(**kwargs) -> Facet:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Regex(**kwargs)->Regex:
def Regex(**kwargs) -> Regex:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Text(**kwargs)->Text:
def Text(**kwargs) -> Text:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]


@staticmethod
def Wildcard(**kwargs)->Wildcard:
def Wildcard(**kwargs) -> Wildcard:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]

filter: list[AnyOperator] = [],
minimum_should_match: int = 0,
**kwargs: Any,
) -> Compound:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Function "src.monggregate.stages.search.base.SearchBase.Compound" is not valid as a type [valid-type]

filter: list[AnyOperator] = [],
minimum_should_match: int = 0,
**kwargs: Any,
) -> Compound:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [mypy] reported by reviewdog 🐶
Perhaps you need "Callable[...]" or a callback protocol?

Comment thread tests/test_coverage.py
import os
from pathlib import Path

import pytest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Ruff] reported by reviewdog 🐶
F401 [*] pytest imported but unused

@VianneyMI VianneyMI marked this pull request as ready for review June 4, 2025 22:00
@VianneyMI VianneyMI merged commit 47ec290 into main Jun 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revival

1 participant