Chore/ev5 0 cleanup tech debt

apps/backend/app/Enums/AssignedRole.php

@@ -4,12 +4,14 @@
 
 enum AssignedRole: string
 {
-    case Rw = 'rw';
+    case KasiPelayanan = 'kasi_pelayanan';
+    case KaurTuUmum = 'kaur_tu_umum';
 
     public function label(): string
     {
         return match ($this) {
-            self::Rw => 'RW',
+            self::KasiPelayanan => 'Kasi Pelayanan',
+            self::KaurTuUmum => 'Kaur TU & Umum',
         };
     }
 }

apps/backend/app/Enums/LetterStatus.php

@@ -11,8 +11,6 @@ enum LetterStatus: string
     case RtRejected = 'rt_rejected';
     case RwApproved = 'rw_approved';
     case RwRejected = 'rw_rejected';
-    case WaitingRevisionWarga = 'waiting_revision_warga';
-    case RejectedRevision = 'rejected_revision';
     case KadusApproved = 'kadus_approved';
     case KadusRejected = 'kadus_rejected';
     case KasiApproved = 'kasi_approved';
@@ -26,8 +24,6 @@ public function label(): string
             self::RtRejected => 'Ditolak RT',
             self::RwApproved => 'Disetujui RW',
             self::RwRejected => 'Ditolak RW',
-            self::WaitingRevisionWarga => 'Menunggu Revisi Warga',
-            self::RejectedRevision => 'Ditolak Revisi',
             self::KadusApproved => 'Disetujui Kadus',
             self::KadusRejected => 'Ditolak Kadus',
             self::KasiApproved => 'Disetujui Kasi Pelayanan',
@@ -40,7 +36,6 @@ public function isRejected(): bool
         return in_array($this, [
             self::RtRejected,
             self::RwRejected,
-            self::RejectedRevision,
             self::KadusRejected,
             self::KasiRejected,
         ], true);

apps/backend/app/Http/Controllers/Api/LetterController.php

@@ -57,57 +57,6 @@ public function show($id)
         ]);
     }
 
-    public function resubmit(Request $request, Letter $letter)
-    {
-        $user = auth()->user();
-
-        if ($letter->submitted_by !== $user->id) {
-            abort(403, 'Anda tidak berwenang mengubah surat ini.');
-        }
-
-        if ($letter->status !== LetterStatus::WaitingRevisionWarga) {
-            abort(422, 'Surat tidak dalam status revisi warga.');
-        }
-
-        if ($letter->revision_count >= 2) {
-            abort(422, 'Batas revisi telah tercapai (maksimal 2x). Silakan ajukan surat baru.');
-        }
-
-        $data = $request->validate([
-            'letter_type_id' => ['nullable', 'exists:letter_types,id'],
-            'purpose' => ['required', 'string', 'max:500'],
-            'payload' => ['nullable', 'array'],
-            'notes' => ['nullable', 'string', 'max:255'],
-        ]);
-
-        DB::transaction(function () use ($letter, $data) {
-            $oldStatus = $letter->status->value;
-
-            $letter->update([
-                'letter_type_id' => $data['letter_type_id'] ?? $letter->letter_type_id,
-                'purpose' => $data['purpose'],
-                'payload' => $data['payload'] ?? $letter->payload,
-                'notes' => $data['notes'] ?? $letter->notes,
-                'status' => LetterStatus::RwApproved->value,
-                'letter_number' => null,
-                'expires_at' => null,
-                'processed_at' => now(),
-            ]);
-
-            $letter->statusLogs()->create([
-                'actor_id' => auth()->id(),
-                'old_status' => $oldStatus,
-                'new_status' => LetterStatus::RwApproved->value,
-                'reason' => $data['notes'] ?? 'Warga mengirim ulang surat hasil revisi.',
-            ]);
-        });
-
-        return response()->json([
-            'message' => 'Surat berhasil dikirim ulang untuk verifikasi.',
-            'data' => $letter->fresh(),
-        ]);
-    }
-
     public function destroy(Letter $letter)
     {
         $user = auth()->user();

apps/backend/app/Services/KasiApprovalService.php

@@ -14,13 +14,12 @@ public function __construct(
         protected OfficialService $officialService
     ) {}
 
-    public function getPendingLetters(User $user)
+    public function getPendingLetters(User $user): \Illuminate\Database\Eloquent\Collection
     {
         return Letter::query()
             ->whereIn('status', [
 
                 LetterStatus::RwApproved,
-                LetterStatus::WaitingRevisionWarga,
                 LetterStatus::KasiApproved,
                 LetterStatus::KasiRejected,
 
@@ -97,47 +96,32 @@ public function approve(
 
             $oldStatus = $letter->status->value;
 
-            if ($data['status'] === 'needs_revision') {
-                $newRevisionCount = $letter->revision_count + 1;
+            $newStatus = $data['status'] === 'approved'
+                ? LetterStatus::KasiApproved->value
+                : LetterStatus::KasiRejected->value;
 
-                // Revisi ke-3+ → auto-reject (maks 2x revisi)
-                if ($newRevisionCount > 2) {
-                    $newStatus = LetterStatus::RejectedRevision->value;
-                } else {
-                    $newStatus = LetterStatus::WaitingRevisionWarga->value;
-                }
+            $letterNumber = null;
+            $expiresAt = null;
 
-                $letter->revision_count = $newRevisionCount;
-                $letterNumber = null;
-                $expiresAt = null;
-            } else {
-                $newStatus = $data['status'] === 'approved'
-                    ? LetterStatus::KasiApproved->value
-                    : LetterStatus::KasiRejected->value;
-
-                $letterNumber = null;
-                $expiresAt = null;
-
-                if ($data['status'] === 'approved') {
-
-                    $letter->approvals()
-                        ->where('approval_level', 'kasi')
-                        ->update([
-                            'approved_by' => $user->id,
-                        ]);
-
-                    $letterNumber = sprintf(
-                        '%03d/%s/%d',
-                        $letter->id,
-                        strtoupper($letter->letterType->code),
-                        now()->year
-                    );
+            if ($data['status'] === 'approved') {
 
-                    if ($letter->letterType->validity_days) {
-                        $expiresAt = now()->addDays(
-                            $letter->letterType->validity_days
-                        );
-                    }
+                $letter->approvals()
+                    ->where('approval_level', 'kasi')
+                    ->update([
+                        'approved_by' => $user->id,
+                    ]);
+
+                $letterNumber = sprintf(
+                    '%03d/%s/%d',
+                    $letter->id,
+                    strtoupper($letter->letterType->code),
+                    now()->year
+                );
+
+                if ($letter->letterType->validity_days) {
+                    $expiresAt = now()->addDays(
+                        $letter->letterType->validity_days
+                    );
                 }
             }
 
@@ -157,21 +141,6 @@ public function approve(
 
             $citizenUser = $letter->citizen->user;
 
-            if ($data['status'] === 'needs_revision') {
-                if ($citizenUser) {
-                    $citizenUser->notify(
-                        new LetterStatusNotification(
-                            $letter,
-                            'Perlu Revisi Data',
-                            'Permohonan surat Anda perlu diperbaiki sebelum verifikasi final.',
-                            'waiting_revision_warga'
-                        )
-                    );
-                }
-
-                return;
-            }
-
             if ($data['status'] === 'approved') {
 
                 if ($citizenUser) {