Skip to content

Add a FILETYPE variable which has the file type - as used by the vscode#16

Open
wdomitrz wants to merge 5 commits into
Vehmloewff:masterfrom
wdomitrz:filetype
Open

Add a FILETYPE variable which has the file type - as used by the vscode#16
wdomitrz wants to merge 5 commits into
Vehmloewff:masterfrom
wdomitrz:filetype

Conversation

@wdomitrz

Copy link
Copy Markdown

The change is fully backward compatible. It's applied on top of #15.

@wdomitrz wdomitrz left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

@Vehmloewff Vehmloewff left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the mr @wdomitrz, and sorry for the late response here.

These are good changes and I want to merge them, but I think we should change a couple things first.

Also, I am going to close the other MR because those commits are here also.

Comment thread README.md Outdated
Comment thread src/run-command.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants