Updated for latest sponge version#4
Open
Evolht wants to merge 2 commits intoVcSaJen:masterfrom
Evolht:master
Open
Updated for latest sponge version#4Evolht wants to merge 2 commits intoVcSaJen:masterfrom Evolht:master
Evolht wants to merge 2 commits intoVcSaJen:masterfrom
Evolht:master
Conversation
added 2 commits
January 20, 2018 19:08
Removed unecessarys in one file, removed cause from file as no longer used. added required version tag in main class file. also had to remove a comment as it was preventing compilation on my pc.
VcSaJen
reviewed
May 3, 2019
| id = "yourcustompaintings", | ||
| name = "YourCustomPaintings", | ||
| description = "Upload your own custom paintings to minecraft server!", | ||
| version = "1.1" |
Owner
There was a problem hiding this comment.
I do not accept pull requests at this point of time, sorry.
P.S. Version is auto-generated with SpongeGradle. This line is unnecessary. Check mcmod.info inside JAR file that was generated after "assembly" gradle task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unecessarys in one file, removed cause from file as no longer used. added required version tag in main class file. also had to remove a comment as it was preventing compilation on my pc.