Make stoneling (tuff variant) use the real polished tuff block.#5552
Merged
Conversation
Member
|
I trust you with my life if my life was Quark, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How this happened: Quark backports. Quark used to have the polished tuff block, so the stoneling tuff variant was looking for the quark polished tuff block (that doesn't exist anymore, therefore getting a null) instead of the vanilla one.
It did give a NPE but I couldn't make this crash neither the client nor the server, BUT, not having the correct polished block meant you couldn't use it to give my boy this awesome look
So this fixes that important problem.