Repository navigation
[ADD] build.sh: Install Chrome and ffmpeg via CHROME_INSTALL build flag - #244
Merged
Merged
Conversation
hugho-ad
force-pushed
the
main-chrome-install-hugho-ad
branch
from
October 8, 2026 17:53
e24040d to
a70eb94
Compare
moylop260
force-pushed
the
main-chrome-install-hugho-ad
branch
from
October 11, 2026 20:07
a70eb94 to
5fd2305
Compare
moylop260
marked this pull request as ready for review
October 11, 2026 20:08
moylop260
force-pushed
the
main-chrome-install-hugho-ad
branch
from
October 11, 2026 20:17
7bea455 to
89ad8fc
Compare
Odoo JS tours need a Chrome binary, and Odoo records a screencast with ffmpeg when a tour fails. The deployv image ships neither, so tours that pass in CI cannot be reproduced inside a t2d container. CHROME_VERSION from variables.sh is honored the same way vxci does: a pinned version is taken from Google's apt pool while it is published there, otherwise from Chrome for Testing. Odoo <= 16 drives tours with the legacy headless mode removed in Chrome 132, so those repos pin an older build that the pool no longer serves. Opt-in like the other build flags, so images that never run tours do not pay the download. Based on vxci implementation: - tools_test.py (install_chrome_commands, install_chrome_for_testing_commands): https://git.vauxoo.com/devops/vxci/blob/master/vxci/tools_test.py - common.py (install_test_deps): https://git.vauxoo.com/devops/vxci/blob/master/vxci/common.py Co-authored-by: Hugo Adan <hugo@vauxoo.com>
moylop260
force-pushed
the
main-chrome-install-hugho-ad
branch
from
October 11, 2026 20:18
89ad8fc to
c90291d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
CHROME_INSTALLbuild flag. When enabled with--build-env-args CHROME_INSTALL, the generated image installs Google Chrome and ffmpeg.CHROME_VERSIONfromvariables.shis honored like vxci does: a pinned version is taken from Google's apt pool while it is published there, otherwise from Chrome for Testing.Based on vxci implementation:
vxci/tools_test.py(install_chrome_commands,install_chrome_for_testing_commands): https://git.vauxoo.com/devops/vxci/blob/master/vxci/tools_test.pyvxci/common.py(install_test_deps): https://git.vauxoo.com/devops/vxci/blob/master/vxci/common.pyWhy
Odoo JS tours need a Chrome binary, and Odoo records a screencast with ffmpeg when a tour fails. The deployv image ships neither, so tours that pass in CI cannot be reproduced inside a t2d container. Odoo <= 16 drives tours with the legacy headless mode removed in Chrome 132, so those repos pin an older build that Google's apt pool no longer serves; Chrome for Testing keeps every build. The flag is opt-in like the others so images that never run tours do not pay the download.
How to Test
travisfile2dockerfile --build-env-args CHROME_INSTALL <repo> <branch>10-build.shand20-run.sh.google-chrome --version(matchesCHROME_VERSIONwhen the repo pins one) andffmpeg -version.odoo-bin -d test -i <module> --test-enable --test-tags /<module> --stop-after-init.Checklist