Bound SA3D channel map parsing - #2
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
Validate SA3D box sizes and channel counts before reading channel map entries. This prevents malformed media from causing unbounded vector growth and keeps extended box headers and position bounds consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser used by Shotcut can trust an oversized SA3D channel count and grow the channel map without regard to the box payload, causing excessive memory use.
This patch validates the minimum SA3D payload, checks box bounds without overflow, accounts for extended box headers, and requires the channel map to fit before reading entries. It also limits the type comparison to the four-byte box name.
Verification:
0xffffffffchannels was rejected safely.