Repository navigation
feat: sign blocklists of up to 16384 keys - #737
Merged
Merged
Conversation
A deleted account's key stays blocked for good, so the signed blocklist only grows. Its cap goes from 4096 to 16384 keys and 1179648 bytes, and the moderation ack and the mod apply pull grow to 1.5 MiB. The ack route now requires Content-Length, cuts a body idle for 5 s and gives a deadline that grows with the length, with no slot taken before the signature check. mod apply waits up to 30 s for pull and ack. An older node reads a list of 4097 to 5796 keys as malformed and keeps its last valid one; above that, app and PWA syncs end in a timeout until they update (docs/protocol.md section 3). Part of #31.
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda e por quê
Cada exclusão de conta deixa a chave do diário na lista de bloqueio para sempre, então o teto de 4096 chaves seria atingido com o tempo.
ackda moderação e opulldomod applysobem para 1,5 MiB./account/mod/api/ackpassa a ser lida como o anexo de uma denúncia: exigeContent-Length, corta um corpo parado por 5 s, e dá um prazo que cresce com o tamanho (cerca de 14,6 s no máximo). Não há vaga reservada antes da assinatura: corpos parados de quem não assina não seguram oackdo operador.mod apply,pulleackesperam até 30 s.Compatibilidade (decisão da manutenção, 2026-11-17: assinar até 16384 já)
tempo esgotado: blocklist, até serem atualizados. O nó do core não trava.Hoje a lista está muito abaixo de 4096 chaves. Item na #224: quando a lista assinada se aproximar de 5800 chaves, conferir antes se as instalações já passaram da versão anterior.
Issue
Parte da #31.
Como verificar
Os passos estão em
docs/verification/feat-blocklist-cap-16384.md. Cada teste novo falha com o valor antigo (conferido revertendo).Checklist
npm run lintenpm run demo(DEMO OK) passamnpm test -- --affected=33b5f24d: 852 de 854 arquivos passam. Dois estouraram o tempo com a máquina carregada:apps/cli/test/update.test.js: passa sozinho (73/73 testes).packages/core/test/private-member-3.test.js("fake bans from an unadmitted writer never inflate a rotation", 30000 ms): também falha sozinho, inclusive namainsem esta mudança (33b5f24), nesta máquina. Na CI do GitHub ele passou nesse mesmo commit. A mudança só altera três constantes empackages/core.docs/changelog/feat-blocklist-cap-16384.mde verificação emdocs/verification/feat-blocklist-cap-16384.md