Repository navigation
feat: add the varandinha screens, navigation and terms - #727
Merged
Merged
Conversation
Two shared screens on hosted nodes: Varandinha (own balcony with the consent sheet, queued acts saved in one garden.play, Quem regou, and a neighbour's balcony with Regar under the node's own help rule) and Varandas da rua (the seeder's street list, kept to the viewer's own follow.list). Entries from the Diario, Ajustes and a member's profile after a peek confirms the garden flag. Queued acts make the top bar arrow, Android Back and Escape ask before leaving; nothing is written on leave. The Vitrine answers on the demo clock. Terms and Privacy gain the Varandinha paragraph, and docs/design.md the LGPD design hypothesis.
Main took Terms version 77, so this branch moves to 78 (legal.js, core TERMS_VERSION, pins, digest, site pages, changelog and verification fragments).
App.js keeps every screen's back guard in a Set now, so Anunciar and Varandinha can both register. The test pins the Set, the loop that asks each guard, and both registrars. The verification file records the CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda e por quê
Quinto e último PR da Varandinha (fase 1), sobre
feat/varandinha-model. Traz as telas, a navegação e os Termos 78.Tela Varandinha (
screens/Varandinha.js):garden.play, e Descartar esvazia a fila.Varandas da rua (
screens/VarandinhaRua.js): as varandas abertas de quem a pessoa segue, 20 por página.follow.list). Cada varanda é conferida ao abrir.Entradas:
gardenapontado pelo semeador está ligado.Elas só existem onde o nó é hospedado: no nó do core não aparece nada. O botão de publicar some nas duas telas.
Termos e Privacidade, versão 78 (a
mainestá em 77), com o parágrafo da Varandinha.docs/design.mdganha a hipótese de desenho para a LGPD. Quem já aceitou precisa aceitar de novo.Vitrine: as telas usam o relógio de demonstração dos dados de exemplo (
src/gardenClock.js, só em bundles da Vitrine), e as datas degarden.statena Vitrine ficam no mesmo relógio. Sem isso, toda planta de exemplo aparecia pronta e nenhuma rega cabia na janela.docs/app.mdedocs/design-review.mddescrevem a tela.Limitações:
apps/cli/scripts/hosted-lab.js) não foi conferido à mão. Ele é coberto porpackages/web-member/test/garden-e2e.test.js, do PRfeat/varandinha-node.ui/Sheet) ainda sobe pode cair no que está atrás dela.Ordem de implantação: primeiro os semeadores, depois o nó hospedado da web, por fim os apps.
Issue
Sem issue (fase 1 da Varandinha).
Como verificar
npm test -w apps/app -- test/nav.test.js test/tabBar.test.js test/composePolish.test.js test/garden.test.js test/vitrine.test.js test/legal.test.jsEXPO_PUBLIC_VARANDA_VITRINE=1, depois denpm run prepare:native -w apps/app), e depois a web. O que foi conferido, e o que não foi, está emdocs/verification/feat-varandinha-app.md.Checklist
npm run lint,npm test(ounpm test -- --affected=origin/main) enpm run demopassamdocs/changelog/<branch>.mde verificação emdocs/verification/<branch>.md, se houver, sem editar o CHANGELOG.md nem acrescentar seção ao docs/verification.md