Skip to content

fix(tailscale): bundle Docker binaries and support host socket - #74

Closed
mahdiwafy wants to merge 1 commit into
Vanszs:mainfrom
mahdiwafy:pr/tailscale-docker
Closed

fix(tailscale): bundle Docker binaries and support host socket#74
mahdiwafy wants to merge 1 commit into
Vanszs:mainfrom
mahdiwafy:pr/tailscale-docker

Conversation

@mahdiwafy

Copy link
Copy Markdown

Summary

  • Bundles tailscale and tailscaled into the Docker image.
  • Adds environment configuration for using the bundled daemon or a host Tailscale socket.
  • Updates docker compose/env examples for the Tailscale Docker flow.

Scope

Focused only on Tailscale-in-Docker runtime support.

Verification

  • npm run lint:undef

@mahdiwafy mahdiwafy closed this Jul 30, 2026
@mahdiwafy
mahdiwafy deleted the pr/tailscale-docker branch July 30, 2026 05:06
@mahdiwafy
mahdiwafy restored the pr/tailscale-docker branch July 30, 2026 05:15
@mahdiwafy mahdiwafy reopened this Jul 30, 2026
@Vanszs

Vanszs commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Request for revision with concrete deployment requirements.

The Docker Tailscale support is relevant, but please separate bundled binaries from host-socket mode.

Please add:

  • pinned version plus checksum/signature verification for downloaded binaries;
  • tested architecture coverage for amd64 and arm64;
  • a test or documented guarantee that host-socket mode never starts, stops, or kills the host daemon;
  • explicit non-root execution/permissions coverage;
  • a minimal capability policy, with CAP_NET_ADMIN enabled only when required;
  • compose documentation showing the socket mount and its security implications.

The application must retain its existing local-daemon fallback and tunnel lifecycle. Please keep Docker privilege changes out of the runtime logic unless required by the selected mode.

@mahdiwafy

Copy link
Copy Markdown
Author

Superseded by focused #88 (tailscale) / #90 (api-key limits).

@mahdiwafy mahdiwafy closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants