Fix unaligned load of m128 floats in ArrayMath::multiplyAccumulate#551
Open
granitrocky wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix unaligned load of m128 floats in ArrayMath::multiplyAccumulate#551granitrocky wants to merge 1 commit intoValveSoftware:masterfrom
granitrocky wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
granitrocky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #546
On linux, this can sometimes cause a segfault when the data is not 16 byte aligned. The other loads are all unaligned, but the final load was expecting aligned data, causing a segfault on linux. On windows, it seems this was not strictly enforced by MSVC, so the loads worked just fine.