Repository navigation
Fix incorrect #include <sys/poll.h> - #2517
Open
WhyNotHugo wants to merge 1 commit into
Open
WhyNotHugo wants to merge 1 commit into
WhyNotHugo wants to merge 1 commit into
Conversation
Collaborator
|
I think we could also just drop this include instead as steamcompmgr doesn't use anything from poll.h that I can see. Does it still build for you with the line removed? |
Building warns: In file included from ../src/steamcompmgr.cpp:60: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> | ^~~~~~~ This include is unused anyway. Remove it entirely. All other files in this project already use the correct path.
Author
|
Builds fine without it. PR updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building warns:
Fix the include to use the correct path.
All other files in this project already use this path.