Repository navigation
rendervulkan, pipewire: fix NV12 storage image support for PipeWire capture - #2502
Open
ErenYeager1836 wants to merge 1 commit into
Open
ErenYeager1836 wants to merge 1 commit into
ErenYeager1836 wants to merge 1 commit into
Conversation
ErenYeager1836
force-pushed
the
fix/nv12-storage-nvidia
branch
from
October 18, 2026 05:07
40b0540 to
8fe5abf
Compare
…apture On drivers where VK_FORMAT_G8_B8R8_2PLANE_420_UNORM lacks STORAGE_IMAGE_BIT (such as NVIDIA proprietary), creating an NV12 storage image requires VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT, VK_IMAGE_CREATE_EXTENDED_USAGE_BIT, and listing the per-plane formats (R8_UNORM and R8G8_UNORM) in VkImageFormatListCreateInfo. Without extended usage, storage writes are invalid under the Vulkan specification and are dropped by the driver, causing solid green frames (0x00 bytes) in Steam Remote Play / PipeWire. This commit: 1. Adds R8_UNORM and R8G8_UNORM to VkImageFormatListCreateInfo and enables MUTABLE_FORMAT_BIT and EXTENDED_USAGE_BIT for YCbCr storage textures. 2. Implements vulkan_supports_nv12_storage() and only advertises NV12 in PipeWire if storage is supported by the device. Closes ValveSoftware#2489
ErenYeager1836
force-pushed
the
fix/nv12-storage-nvidia
branch
from
October 20, 2026 12:30
8fe5abf to
13178bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On drivers where
VK_FORMAT_G8_B8R8_2PLANE_420_UNORMlacksSTORAGE_IMAGE_BIT(such as NVIDIA proprietary), creating an NV12 storage image requiresVK_IMAGE_CREATE_MUTABLE_FORMAT_BIT,VK_IMAGE_CREATE_EXTENDED_USAGE_BIT, and listing the per-plane formats (R8_UNORMandR8G8_UNORM) inVkImageFormatListCreateInfo. Without extended usage, storage writes are invalid under the Vulkan specification and are dropped by the driver, causing solid green frames (all zero bytes) in Steam Remote Play / PipeWire.Furthermore,
dst_lumaanddst_chromaindescriptor_set.hwere declared with anrgba8format qualifier instead ofr8andrg8, violating storage image format matching with the underlying plane views.This PR:
R8_UNORMandR8G8_UNORMtoVkImageFormatListCreateInfoand enablesMUTABLE_FORMAT_BITandEXTENDED_USAGE_BITfor YCbCr storage textures inCVulkanTexture::BInit.r8andrg8format qualifiers fordst_lumaanddst_chromawhenNV12_EXPORTis defined.vulkan_supports_nv12_storage()and only advertises NV12 in PipeWire if storage is supported by the device.Closes #2489