Repository navigation
rendervulkan: join present wait thread on shutdown - #2494
Merged
matte-schwartz merged 1 commit intoOct 20, 2026
Merged
Conversation
connormclaud
marked this pull request as ready for review
October 16, 2026 20:27
When using --backend sdl, present_wait_thread_func was detached and could race with backend destruction during exit, crashing in CalcNextWakeupTime when dereferencing a null s_pBackend. Manage the thread with a std::jthread and shut it down cleanly before destroying the backend in steamcompmgr_exit. Fixes ValveSoftware#2402
connormclaud
force-pushed
the
fix-present-wait-shutdown
branch
from
October 20, 2026 18:50
51812b0 to
61b0f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using --backend sdl, present_wait_thread_func was detached and could
race with backend destruction during exit, crashing in CalcNextWakeupTime
when dereferencing a null s_pBackend.
Manage the thread with a std::jthread and shut it down cleanly before
destroying the backend in steamcompmgr_exit and CSDLBackend.
Fixes #2402