Improving the scrolling performance

[scart88]

Lighthouse throw the following recommendation for improving the scrolling performance:

Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance

This PR should address the errors, however, I wasn't able to test locally.

[Valexr]

I can't test this locally too - haven't lighthouse ;)
With passive listeners we can't use event modifiers like e.preventDefault()... & other - they are using for avoiding native browser behaviour
Advertising network want to all sites will be reachable for she's logic... ;)

[Valexr]

Tx for your's collab 👍🏻

[scart88]

I think Lighthouse complains because the scroll event doesn't have passive: true.
I notice that scroll function doesn't use preventDefault so I thought it would be safe to add passive: true, however, I wasn't able to run the build locally.

[
            'scroll',
            () => {
                to(INDEX);
                GRAVITY = 2;
            },
],

[Valexr]

you need use pnpm for building

[Valexr]

not scroll event

[scart88]

Oh I see. I tried with pnpm, however, I got several errors and the build failed.

Dang!

Do you think this line would be this line?
https://github.com/Valexr/Slidy/blob/main/packages/core/src/lib/slidy.ts#L86

Something like this would make a difference? I notice that onWheel never calls e.preventDefault();
node.addEventListener('wheel', throttle(onWheel, DURATION, CLAMP), { passive: true });

Thank you so much for your attention!

[Valexr]

I think lighthouse talk about specific places of prevention passive mode. And recommends removing them to allegedly increase the performance of the page scroll.