Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces verbosity for the cargo-insta-update-snapshots MCP tool by switching it to run cargo test with INSTA_UPDATE and adding explicit output verbosity controls, while also slightly tightening workspace auto-detection behavior/logging.
Changes:
- Rework
cargo-insta-update-snapshotsto usecargo test+INSTA_UPDATE(addsforce+output_verbosity, removes several prior cargo-insta-specific inputs). - Update tool documentation (
tools.md) to reflect the new inputs/behavior. - Refresh insta snapshots for the updated command-line args.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools.md | Updates the documented schema/inputs for cargo-insta-update-snapshots (adds force, output_verbosity, removes prior fields). |
| src/workspace.rs | Adds an early return + warning when the client lacks roots capability; minor cleanup in URI-to-path conversion. |
| src/tools/cargo_insta.rs | Implements the new cargo test + INSTA_UPDATE command building and adds verbosity/force options; updates unit tests accordingly. |
| src/tools/snapshots/rust_mcp_server__tools__cargo_insta__tests__cargo_insta_update_snapshots_nextest_runner_args.snap | Deletes snapshot for removed nextest/unreferenced args behavior. |
| src/tools/snapshots/rust_mcp_server__tools__cargo_insta__tests__cargo_insta_update_snapshots_manifest_path_args.snap | Updates expected args for --manifest-path flow (now includes --quiet, removes old cargo-insta args). |
| src/tools/snapshots/rust_mcp_server__tools__cargo_insta__tests__cargo_insta_update_snapshots_features_and_targets_args.snap | Updates expected args to match new default quiet behavior and removal of cargo-insta subcommand. |
| src/tools/snapshots/rust_mcp_server__tools__cargo_insta__tests__cargo_insta_update_snapshots_default_args.snap | Updates expected default args (now cargo test --workspace --quiet). |
| src/tools/snapshots/rust_mcp_server__tools__cargo_insta__tests__cargo_insta_update_snapshots_all_features_args.snap | Updates expected args (now includes --quiet, removes cargo-insta args). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.