ci: codesign + staple the DMG, and staple the app - #7
Merged
Merged
Conversation
The release notarized + stapled the DMG but never *codesigned* the DMG
container, so `spctl -a -t open` rejected it ("no usable signature") — a
downloaded DMG could prompt Gatekeeper on mount even though the app inside is
notarized. The app was also only covered by the DMG's notarization, not stapled
itself (weaker offline).
package-signed.sh now: (1) notarizes the app and staples the *app* before
building the DMG, so the bundle carries its ticket offline / once copied out;
(2) codesigns the DMG, then notarizes + staples the DMG. Two notary submissions.
Gated on secrets as before; ad-hoc fallback unchanged.
Verified live earlier as v0.2.12: app accepted/notarized, but the DMG showed
"no usable signature" on `spctl -t open` — this closes that gap.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the notarized-release PR (#6). Live‑testing release v0.2.12 showed the app is correctly notarized + accepted, but the DMG container itself was never codesigned — so:
A downloaded
.dmgcan therefore prompt Gatekeeper on mount, even though the app inside is fine. The app was also only covered by the DMG's notarization, not stapled itself (weaker when fully offline).Change (
scripts/package-signed.sh)Reordered to Apple's recommended flow:
LP100AExtension.appex→ sign inside-outTwo notary submissions now. Still gated on secrets; ad-hoc fallback unchanged. A small
notarize()helper removes duplication.Result
Closes the
spctl -t opengap: the DMG mounts without a Gatekeeper prompt, and the app is stapled for offline launch. Same template change is applied to LP-700 (#13), BPF (#13), and Antenna (#28) so their first signed release is clean.🤖 Generated with Claude Code