Audit/production readiness 20260221#60
Merged
wallydz merged 2 commits intoVPNht:vpnht-rewritefrom Feb 21, 2026
Merged
Conversation
added 2 commits
February 21, 2026 20:33
…. Baseline verified. Swarm consolidated.
The previous implementation used format!() to build shell scripts, allowing potential command injection if cmd or args contained special characters like quotes, backticks, or semicolons. Fix by implementing proper shell escaping using single-quote escaping, which safely handles all special characters including embedded quotes. Before (vulnerable): do shell script "cmd args" with administrator privileges After (safe): do shell script 'cmd' 'arg1' 'arg2' with administrator privileges Also improved Command builder to use .arg() instead of .args() with mutable Vec references for cleaner code.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## vpnht-rewrite #60 +/- ##
=================================================
+ Coverage 27.22% 27.50% +0.27%
=================================================
Files 19 19
Lines 2755 2767 +12
Branches 115 117 +2
=================================================
+ Hits 750 761 +11
- Misses 1996 1997 +1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes in this PR.
Type of Change
Related Issues
Fixes #(issue number)
Closes #(issue number)
Checklist
Security Checklist
Testing
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Context
Add any other context about the pull request here.